Add Einsum to MIGraphX supported op list #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalinic
changed the title
TedThemistokleous
approved these changes
Oct 28, 2024
|
Why did this merge to main instead of a release branch? We don't touch main in our fork. It should be a mirror of upstream. |
Ah likely I need to add that as part of the rocm6.3 branch then as a cherry-pick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Einsum op to supported op list in migraphx_execution_provider.cc
Motivation and Context
Einsum ONNX op is supported by MIGraphX since ROCm 6.2. Since SD3 needs the Einsum op, the op currently falls back to CPU ep when using MIGraphX. This causes runtime exception on Cast op on Windows in some cases. After adding the Einsum to the op list the issue is no longer present.